Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1095573002: Revert of Migrate error messages, part 2. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
Reviewers:
mvstanton, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Migrate error messages, part 2. (patchset #1 id:1 of https://codereview.chromium.org/1086313003/) Reason for revert: [Sheriff]: This changes layout test expectations e.g. http://build.chromium.org/p/client.v8/builders/V8-Blink%20Win/builds/2964 Original issue's description: > Migrate error messages, part 2. > > Motivation for this is reducing the size of the native context. > > Committed: https://crrev.com/d3b788df0a4ccfedbe6e1df5e214cb6ba2792a65 > Cr-Commit-Position: refs/heads/master@{#27878} TBR=mvstanton@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d881baaced6fa4f7839a7678cd0eeb9a5075275d Cr-Commit-Position: refs/heads/master@{#27889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -270 lines) Patch
M src/array.js View 7 chunks +17 lines, -7 lines 0 comments Download
M src/array-iterator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/collection.js View 15 chunks +38 lines, -32 lines 0 comments Download
M src/collection-iterator.js View 7 chunks +14 lines, -14 lines 0 comments Download
M src/execution.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/factory.h View 2 chunks +8 lines, -20 lines 0 comments Download
M src/factory.cc View 2 chunks +10 lines, -18 lines 0 comments Download
M src/generator.js View 3 chunks +6 lines, -6 lines 0 comments Download
M src/harmony-array.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/harmony-typedarray.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +3 lines, -11 lines 0 comments Download
M src/messages.js View 5 chunks +48 lines, -30 lines 0 comments Download
M src/objects.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M src/regexp.js View 4 chunks +8 lines, -8 lines 0 comments Download
M src/runtime.js View 5 chunks +5 lines, -5 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-iterator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/symbol.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/typedarray.js View 5 chunks +20 lines, -14 lines 0 comments Download
M src/v8natives.js View 4 chunks +7 lines, -7 lines 0 comments Download
M src/weak-collection.js View 9 chunks +16 lines, -16 lines 0 comments Download
D test/mjsunit/messages.js View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Migrate error messages, part 2.
5 years, 8 months ago (2015-04-16 14:33:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095573002/1
5 years, 8 months ago (2015-04-16 14:33:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 14:33:44 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 14:33:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d881baaced6fa4f7839a7678cd0eeb9a5075275d
Cr-Commit-Position: refs/heads/master@{#27889}

Powered by Google App Engine
This is Rietveld 408576698