Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tool/input_sdk/private/native_typed_data.dart

Issue 1095563003: [refactor] js_codegen: remove currentClass, simplify visitSimpleIdentifier (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tool/input_sdk/private/native_typed_data.dart
diff --git a/tool/input_sdk/private/native_typed_data.dart b/tool/input_sdk/private/native_typed_data.dart
index 84b25bc52c1d630b83202a160314f1c34bb2b4ba..2f94f86eaf190576dd12e062d1a3ed9cd186b2c3 100644
--- a/tool/input_sdk/private/native_typed_data.dart
+++ b/tool/input_sdk/private/native_typed_data.dart
@@ -857,7 +857,8 @@ class NativeByteData extends NativeTypedData implements ByteData {
abstract class NativeTypedArray extends NativeTypedData
implements JavaScriptIndexingBehavior {
- int get length => JS('JSUInt32', '#.length', this);
+ // TODO(jmesserly): moved `length` to subclass to (somewhat) mitigate
+ // <https://github.com/dart-lang/dev_compiler/issues/138>
void _setRangeFast(int start, int end,
NativeTypedArray source, int skipCount) {
@@ -887,6 +888,8 @@ abstract class NativeTypedArrayOfDouble
extends NativeTypedArray
with ListMixin<double>, FixedLengthListMixin<double> {
+ int get length => JS('JSUInt32', '#.length', this);
+
num operator[](int index) {
_checkIndex(index, length);
return JS('num', '#[#]', this, index);
@@ -912,6 +915,8 @@ abstract class NativeTypedArrayOfInt
with ListMixin<int>, FixedLengthListMixin<int>
implements List<int> {
+ int get length => JS('JSUInt32', '#.length', this);
+
// operator[]() is not here since different versions have different return
// types

Powered by Google App Engine
This is Rietveld 408576698