Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: lib/runtime/dart/_native_typed_data.js

Issue 1095563003: [refactor] js_codegen: remove currentClass, simplify visitSimpleIdentifier (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/codegen/js_codegen.dart » ('j') | lib/src/codegen/js_codegen.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_native_typed_data.js
diff --git a/lib/runtime/dart/_native_typed_data.js b/lib/runtime/dart/_native_typed_data.js
index 4c9290b64c65b270c06640e4ccf0274e0203fb17..8ea923657f7b29efa1822cc0ca5870f45bff8b8f 100644
--- a/lib/runtime/dart/_native_typed_data.js
+++ b/lib/runtime/dart/_native_typed_data.js
@@ -582,9 +582,6 @@ var _native_typed_data;
dart.defineNamedConstructor(NativeByteData, 'view');
let _setRangeFast = Symbol('_setRangeFast');
class NativeTypedArray extends NativeTypedData {
- get length() {
- return dart.as(this.length, core.int);
Jennifer Messerly 2015/04/16 22:50:30 this would've overflowed the stack
- }
[_setRangeFast](start, end, source, skipCount) {
let targetLength = this.length;
this[_checkIndex](start, dart.notNull(targetLength) + 1);
@@ -606,6 +603,9 @@ var _native_typed_data;
}
NativeTypedArray[dart.implements] = () => [_js_helper.JavaScriptIndexingBehavior];
class NativeTypedArrayOfDouble extends dart.mixin(NativeTypedArray, collection.ListMixin$(core.double), _internal.FixedLengthListMixin$(core.double)) {
+ get [core.$length]() {
+ return dart.as(this.length, core.int);
+ }
[core.$get](index) {
this[_checkIndex](index, this[core.$length]);
return this[index];
@@ -625,6 +625,9 @@ var _native_typed_data;
}
}
class NativeTypedArrayOfInt extends dart.mixin(NativeTypedArray, collection.ListMixin$(core.int), _internal.FixedLengthListMixin$(core.int)) {
+ get [core.$length]() {
+ return dart.as(this.length, core.int);
+ }
[core.$set](index, value) {
this[_checkIndex](index, this[core.$length]);
this[index] = value;
« no previous file with comments | « no previous file | lib/src/codegen/js_codegen.dart » ('j') | lib/src/codegen/js_codegen.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698