Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1095553005: Replace ActionBarActivity with AppCompatActivity. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ActionBarActivity with AppCompatActivity. ActionBarActivity was deprecated in AppCompat 22.1.0. This CL renames all usages of ActionBarActivity in Chrome. BUG=479858 Committed: https://crrev.com/7a8e49d5d15c3cbb2671285d6cda1174759f5ff7 Cr-Commit-Position: refs/heads/master@{#326717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-24 00:44:18 UTC) #2
newt (away)
lgtm be sure to also update any places where we use android.support.v7.app.ActionBar (they're all downstream, ...
5 years, 8 months ago (2015-04-24 00:50:31 UTC) #3
newt (away)
also I'd update the commit message to "Replace ActionBarActivity with AppCompatActivity"
5 years, 8 months ago (2015-04-24 00:56:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095553005/1
5 years, 8 months ago (2015-04-24 01:10:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 01:40:10 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 01:41:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a8e49d5d15c3cbb2671285d6cda1174759f5ff7
Cr-Commit-Position: refs/heads/master@{#326717}

Powered by Google App Engine
This is Rietveld 408576698