Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 1095543003: Extend variadic template hack for /analyze. (Closed)

Created:
5 years, 8 months ago by brucedawson
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extend variadic template hack for /analyze. A recent Chrome change broke the /analyze builder by using a larger Tuple than had been allowed for in the previous VC++ bug workaround. This change unblocks the /analyze builder and will not affect /analyze builds. The /analyze error is: e:\b\build\slave\chromium_windows_analyze\build\src\base\tuple.h(99) : error C2027: use of undefined type 'MakeIndexSequenceImpl<0xc>' e:\b\build\slave\chromium_windows_analyze\build\src\device\usb\usb_device_handle_impl.cc(608) and came from https://codereview.chromium.org/980023002 R=thakis@chromium.org BUG=427616 Committed: https://crrev.com/35709e179d83a2d436700c7a3974b70a82419d89 Cr-Commit-Position: refs/heads/master@{#325877}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/tuple.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
brucedawson
5 years, 8 months ago (2015-04-20 15:18:55 UTC) #1
Nico
lgtm (do you have a link to the cl that requires this many tuple elements, ...
5 years, 8 months ago (2015-04-20 15:26:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095543003/1
5 years, 8 months ago (2015-04-20 15:37:01 UTC) #4
brucedawson
I added details about the break to the CL description.
5 years, 8 months ago (2015-04-20 16:21:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 18:20:47 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 18:21:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35709e179d83a2d436700c7a3974b70a82419d89
Cr-Commit-Position: refs/heads/master@{#325877}

Powered by Google App Engine
This is Rietveld 408576698