Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 Name: icu | 1 Name: icu |
| 2 URL: http://site.icu-project.org/ | 2 URL: http://site.icu-project.org/ |
| 3 Version: 4.6 | 3 Version: 4.6 |
| 4 License: MIT | 4 License: MIT |
| 5 Security Critical: yes | 5 Security Critical: yes |
| 6 | 6 |
| 7 Description: | 7 Description: |
| 8 This directory contains the source code of ICU 4.6 for C/C++ | 8 This directory contains the source code of ICU 4.6 for C/C++ |
| 9 | 9 |
| 10 1. It was obtained with the following: | 10 1. It was obtained with the following: |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 27 In case the file has to be updated you can do: | 27 In case the file has to be updated you can do: |
| 28 cd /home/ports/textproc/icu4c && make configure | 28 cd /home/ports/textproc/icu4c && make configure |
| 29 | 29 |
| 30 - Rename it to 'plinux.h', 'pfreebsd.h', 'popenbsd.h' and 'pmac.h' | 30 - Rename it to 'plinux.h', 'pfreebsd.h', 'popenbsd.h' and 'pmac.h' |
| 31 | 31 |
| 32 - Apply patches/pmach.h.patch on Mac to pmac.h | 32 - Apply patches/pmach.h.patch on Mac to pmac.h |
| 33 | 33 |
| 34 - On Android, the pandroid.h was generated by copying plinux.h to | 34 - On Android, the pandroid.h was generated by copying plinux.h to |
| 35 pandroid.h and applying the patches/pandroid.h.patch. | 35 pandroid.h and applying the patches/pandroid.h.patch. |
| 36 | 36 |
| 37 - For NaCl (icu_untrusted), the pnacl.h was generated by copying plinux.h to | |
| 38 pnacl.h and applying the patches/pnacl.h.patch. | |
|
Mark Mentovai
2013/12/20 19:03:00
So this happens to the original plinux.h, not the
Sergey Ulanov
2013/12/20 19:36:21
Good point - I didn't notice there is another patc
| |
| 39 | |
| 37 - Apply the CL at https://codereview.chromium.org/15973007/ to plinux.h | 40 - Apply the CL at https://codereview.chromium.org/15973007/ to plinux.h |
| 38 | 41 |
| 39 3. The following directories were removed because they're not used by Chromium | 42 3. The following directories were removed because they're not used by Chromium |
| 40 at the moment: | 43 at the moment: |
| 41 as_is | 44 as_is |
| 42 packaging | 45 packaging |
| 43 source/extra | 46 source/extra |
| 44 source/sample | 47 source/sample |
| 45 source/layout | 48 source/layout |
| 46 source/layoutex | 49 source/layoutex |
| 47 | 50 |
| 48 | 51 |
| 49 4. The word breaking for Chinese and Japanese were modified to use a word | 52 4. The word breaking for Chinese and Japanese were modified to use a word |
| 50 frequency list with the following patch and cjdict.txt. | 53 frequency list with the following patch and cjdict.txt. |
| 51 | 54 |
| 52 - patches/segmentation.patch : | 55 - patches/segmentation.patch : |
| 53 Adds a dictionary (word-frequency)-based word breaking for CJK | 56 Adds a dictionary (word-frequency)-based word breaking for CJK |
| 54 (Korean is supported in the code, but it does not do anything | 57 (Korean is supported in the code, but it does not do anything |
| 55 because we don't have a Korean word-list.) | 58 because we don't have a Korean word-list.) |
| 56 | 59 |
| 57 - source/data/brkitr/cjdict.txt : | 60 - source/data/brkitr/cjdict.txt : |
| 58 Chinese and Japanese word frequency list. | 61 Chinese and Japanese word frequency list. |
| 59 See the file for license/copyright notice | 62 See the file for license/copyright notice |
| 60 | 63 |
| 61 - source/data/brkitr/cc_edict.txt : | 64 - source/data/brkitr/cc_edict.txt : |
| (...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 168 Because we removed layout and layoutex directories in step 3, | 171 Because we removed layout and layoutex directories in step 3, |
| 169 'runConfigureICU Linux' will fail even with '--disable-layout'. A | 172 'runConfigureICU Linux' will fail even with '--disable-layout'. A |
| 170 work-around is to have a copy of our icu tree in a separate build directory | 173 work-around is to have a copy of our icu tree in a separate build directory |
| 171 and add back directories we removed in step 3 before | 174 and add back directories we removed in step 3 before |
| 172 running 'runConfigure'. | 175 running 'runConfigure'. |
| 173 | 176 |
| 174 'make' will fail in the 1st pass. Copy source/data/in/coll/invuca.icu | 177 'make' will fail in the 1st pass. Copy source/data/in/coll/invuca.icu |
| 175 to {BUILD_DIR_ROOT}/data/out/build/icudt46l/coll and re-run 'make' | 178 to {BUILD_DIR_ROOT}/data/out/build/icudt46l/coll and re-run 'make' |
| 176 in {BUILD_DIR_ROOT}/data. | 179 in {BUILD_DIR_ROOT}/data. |
| 177 | 180 |
| 178 'make' will fail again when pkgdata looks for css3transform.res. Edit | 181 'make' will fail again when pkgdata looks for css3transform.res. Edit |
| 179 data/out/tmp/icudata.lst to replace 'css3transform.res' with 'root.res'. | 182 data/out/tmp/icudata.lst to replace 'css3transform.res' with 'root.res'. |
| 180 (see http://bugs.icu-project.org/trac/ticket/10570 ) and run 'make' again. | 183 (see http://bugs.icu-project.org/trac/ticket/10570 ) and run 'make' again. |
| 181 | 184 |
| 182 | 185 |
| 183 - source/data/in/icudt46l.dat : Built on Linux with all the patches | 186 - source/data/in/icudt46l.dat : Built on Linux with all the patches |
| 184 above applied. This file will be generated in | 187 above applied. This file will be generated in |
| 185 {BUILD_DIR_ROOT}/data/out/tmp. | 188 {BUILD_DIR_ROOT}/data/out/tmp. |
| 186 | 189 |
| 187 - windows/icudt.dll : With icudt46l.dat in place, all the patches applied | 190 - windows/icudt.dll : With icudt46l.dat in place, all the patches applied |
| 188 and header files moved (#11 below), generated by building icudt_build | 191 and header files moved (#11 below), generated by building icudt_build |
| 189 project of build/icudt_build.sln on Windows. icudt46.dll is | 192 project of build/icudt_build.sln on Windows. icudt46.dll is |
| 190 generated in bin/{Release,Debug} and copied to windows/icudt.dll | 193 generated in bin/{Release,Debug} and copied to windows/icudt.dll |
| 191 and checked in. Note that we drop the version number ('46') from the | 194 and checked in. Note that we drop the version number ('46') from the |
| 192 dll name to avoind having to update our build scripts/configuration | 195 dll name to avoind having to update our build scripts/configuration |
| 193 files everytime ICU is upgraded to a new version. | 196 files everytime ICU is upgraded to a new version. |
| 194 | 197 |
| (...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 248 - upstream bug: http://bugs.icu-project.org/trac/ticket/8290 | 251 - upstream bug: http://bugs.icu-project.org/trac/ticket/8290 |
| 249 | 252 |
| 250 17. Fix a use of uninitialized memory bug in regular expression matching | 253 17. Fix a use of uninitialized memory bug in regular expression matching |
| 251 - patches/rematch.patch | 254 - patches/rematch.patch |
| 252 - upstream bug: http://bugs.icu-project.org/trac/ticket/8824 | 255 - upstream bug: http://bugs.icu-project.org/trac/ticket/8824 |
| 253 | 256 |
| 254 18. Make it compile with -Werror on gcc 4.6 | 257 18. Make it compile with -Werror on gcc 4.6 |
| 255 - patches/gcc46.patch (ToT upstream does not have this code any more). | 258 - patches/gcc46.patch (ToT upstream does not have this code any more). |
| 256 | 259 |
| 257 19. Fix four out of bounds memory access error in common/uloc.c | 260 19. Fix four out of bounds memory access error in common/uloc.c |
| 258 and common/uresbund.c | 261 and common/uresbund.c |
| 259 - patches/uloc.patch | 262 - patches/uloc.patch |
| 260 - upstream bug: | 263 - upstream bug: |
| 261 1. http://bugs.icu-project.org/trac/ticket/8984 (_canonicalize) | 264 1. http://bugs.icu-project.org/trac/ticket/8984 (_canonicalize) |
| 262 2. http://bugs.icu-project.org/trac/ticket/9114 (_getKeywords) | 265 2. http://bugs.icu-project.org/trac/ticket/9114 (_getKeywords) |
| 263 3. http://bugs.icu-project.org/trac/ticket/8812 (uresbund) | 266 3. http://bugs.icu-project.org/trac/ticket/8812 (uresbund) |
| 264 http://bugs.icu-project.org/trac/ticket/8813 (uresbund) | 267 http://bugs.icu-project.org/trac/ticket/8813 (uresbund) |
| 265 4. http://bugs.icu-project.org/trac/ticket/10250 (_getKeywords) | 268 4. http://bugs.icu-project.org/trac/ticket/10250 (_getKeywords) |
| 266 | 269 |
| 267 20. Fix a null pointer error in ubrk_setText in ubrk.cpp. | 270 20. Fix a null pointer error in ubrk_setText in ubrk.cpp. |
| 268 - patches/ubrk.patch | 271 - patches/ubrk.patch |
| 269 - upstream bug : http://bugs.icu-project.org/trac/ticket/9115 | 272 - upstream bug : http://bugs.icu-project.org/trac/ticket/9115 |
| 270 | 273 |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 284 24. Fix compilation errors on VS2012 and above. | 287 24. Fix compilation errors on VS2012 and above. |
| 285 - patches/vs2012.patch | 288 - patches/vs2012.patch |
| 286 | 289 |
| 287 25. Fix a buffer overflow in UTF-16/32 detection. | 290 25. Fix a buffer overflow in UTF-16/32 detection. |
| 288 - patches/csetdet.patch | 291 - patches/csetdet.patch |
| 289 - upstream bug: http://bugs.icu-project.org/trac/ticket/10318 | 292 - upstream bug: http://bugs.icu-project.org/trac/ticket/10318 |
| 290 | 293 |
| 291 26. Add BreakIterator::getRuleStatus | 294 26. Add BreakIterator::getRuleStatus |
| 292 - patches/breakiterator.patch | 295 - patches/breakiterator.patch |
| 293 - Copy and paste BreakIterator::getRuleStatus API from ICU 52 | 296 - Copy and paste BreakIterator::getRuleStatus API from ICU 52 |
| OLD | NEW |