patches/pnacl.h.patch - Issue 109553005: Compile ICU for [P]NaCl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: patches/pnacl.h.patch

Issue 109553005: Compile ICU for [P]NaCl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 --- a/source/common/unicode/pnacl.h

	2 +++ b/source/common/unicode/pnacl.h

	3 @@ -282,8 +282,10 @@

	4 #if 1

	5 #define U_TZSET tzset

	6 #endif

	7 -#if !defined(__UCLIBC__)

	8 +#if 1
	Mark Mentovai 2013/12/20 19:42:27 Something’s weird. The actual .h has #if defined(_ Something’s weird. The actual .h has #if defined(__GLIBC__) here. If this really was supposed to be #if 1, the #else would be kind of pointless. Sergey Ulanov 2013/12/20 19:48:04 sorry, my bad, I updated this line instead of the Show quoted text On 2013/12/20 19:42:27, Mark Mentovai wrote: > Something’s weird. The actual .h has #if defined(__GLIBC__) here. If this really > was supposed to be #if 1, the #else would be kind of pointless. sorry, my bad, I updated this line instead of the previous one.
	9 #define U_TIMEZONE __timezone

	10 +#else

	11 +#define U_TIMEZONE _timezone

	12 #endif

	13 #if 1

	14 #define U_TZNAME tzname

OLD	NEW

« no previous file with comments | « patches/platform.patch ('k') | source/common/unicode/pnacl.h » ('j') | no next file with comments »