[Telemetry] Make StartVideoCapture start capturing synchronously.

[Telemetry] Make StartVideoCapture start capturing synchronously.

Previously it just asynchronously started capture.

BUG=323813
R=bulach@chromium.org, skyostil@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239640

[bulach, 2013-12-09 12:25:02]

lgtm if sami is happy.. thanks!

[Sami, 2013-12-09 15:27:08]

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
File build/android/pylib/screenshot.py (right):

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
build/android/pylib/screenshot.py:66: self._args += ['shell', 'screenrecord',
'--verbose']
Mind adding a keyword argument for this? The standalone
build/android/screenshot.py gets a little messy with always-on verbose.

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
build/android/pylib/screenshot.py:77: self._recorder_stdout =
tempfile.mkstemp()[1]
Please remove this file when we're done with it.

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
build/android/pylib/screenshot.py:87: for line in
open(self._recorder_stdout).readlines():
Nit: no need for .readlines().

[tonyg, 2013-12-09 16:47:12]

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
File build/android/pylib/screenshot.py (right):

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
build/android/pylib/screenshot.py:66: self._args += ['shell', 'screenrecord',
'--verbose']
On 2013/12/09 15:27:09, Sami wrote:
> Mind adding a keyword argument for this? The standalone
> build/android/screenshot.py gets a little messy with always-on verbose.

Maybe I'm missing your point, but just to be clear, this doesn't change the
command line output. All of the additional output is swallowed by the temp file.

$ build/android/screenshot.py --video
Recording. Press Enter to stop...
Video written to
/usr/local/google/code/chromium/src/screen-recording-2013-12-09-083639.mp4

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
build/android/pylib/screenshot.py:77: self._recorder_stdout =
tempfile.mkstemp()[1]
On 2013/12/09 15:27:09, Sami wrote:
> Please remove this file when we're done with it.

Done.

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
build/android/pylib/screenshot.py:87: for line in
open(self._recorder_stdout).readlines():
On 2013/12/09 15:27:09, Sami wrote:
> Nit: no need for .readlines().

Mind=>blown :) I had no idea that worked.

[Sami, 2013-12-09 17:14:30]

lgtm, thanks Tony.

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
File build/android/pylib/screenshot.py (right):

https://codereview.chromium.org/109553002/diff/1/build/android/pylib/screensh...
build/android/pylib/screenshot.py:66: self._args += ['shell', 'screenrecord',
'--verbose']
On 2013/12/09 16:47:12, tonyg wrote:
> Maybe I'm missing your point, but just to be clear, this doesn't change the
> command line output. All of the additional output is swallowed by the temp
file.

Ack, sorry, I only tried half of your patch to see what it would do :)

[commit-bot: I haz the power, 2013-12-09 17:16:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/109553002/20001

[tonyg, 2013-12-10 01:51:09]

Committed patchset #2 manually as r239640 (presubmit successful).