Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: cc/output/renderer_pixeltest.cc

Issue 1095513004: Remove SK_SUPPORT_LEGACY_COLOR32_MATH (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: extra Mac rebaselines Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | skia/config/SkUserConfig.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/renderer_pixeltest.cc
diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc
index bfad4ba0c1e9d45e49035ebd938d205376499c8f..269ec585a15a14db189e53ff5cff8090e1dc6060 100644
--- a/cc/output/renderer_pixeltest.cc
+++ b/cc/output/renderer_pixeltest.cc
@@ -1337,10 +1337,11 @@ TYPED_TEST(RendererPixelTest, FastPassSaturateFilter) {
pass_list.push_back(child_pass.Pass());
pass_list.push_back(root_pass.Pass());
+ // This test blends slightly differently with the software renderer vs. the gl
+ // renderer so use a fuzzy comparator.
EXPECT_TRUE(this->RunPixelTest(
- &pass_list,
- base::FilePath(FILE_PATH_LITERAL("blue_yellow_alpha.png")),
- ExactPixelComparator(true)));
+ &pass_list, base::FilePath(FILE_PATH_LITERAL("blue_yellow_alpha.png")),
+ FuzzyForSoftwareOnlyPixelComparator<TypeParam>(false)));
}
TYPED_TEST(RendererPixelTest, FastPassFilterChain) {
@@ -1408,10 +1409,12 @@ TYPED_TEST(RendererPixelTest, FastPassFilterChain) {
pass_list.push_back(child_pass.Pass());
pass_list.push_back(root_pass.Pass());
+ // This test blends slightly differently with the software renderer vs. the gl
+ // renderer so use a fuzzy comparator.
EXPECT_TRUE(this->RunPixelTest(
&pass_list,
base::FilePath(FILE_PATH_LITERAL("blue_yellow_filter_chain.png")),
- ExactPixelComparator(true)));
+ FuzzyForSoftwareOnlyPixelComparator<TypeParam>(false)));
}
TYPED_TEST(RendererPixelTest, FastPassColorFilterAlphaTranslation) {
« no previous file with comments | « no previous file | skia/config/SkUserConfig.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698