src/objects.cc - Issue 1095503002: Add missing Handle to GetOrCreatePrototypeChainValidityCell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1095503002: Add missing Handle to GetOrCreatePrototypeChainValidityCell (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index eac53cbab5db237308536d63aa8e0b6a1ca28258..037d33c5039daeec1dac8458ad459d8ddf93985c 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -10126,8 +10126,8 @@ Handle<Cell> Map::GetOrCreatePrototypeChainValidityCell(Handle<Map> map,

PrototypeIterator iter(isolate, prototype);

prototype = Handle<JSObject>::cast(PrototypeIterator::GetCurrent(iter));

}

- PrototypeInfo* proto_info =

- PrototypeInfo::cast(prototype->map()->prototype_info());

+ Handle<PrototypeInfo> proto_info(

+ PrototypeInfo::cast(prototype->map()->prototype_info()));

Object* maybe_cell = proto_info->validity_cell();

// Return existing cell if it's still valid.

if (maybe_cell->IsCell()) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »