Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1095483003: Makes AKEYCODE_BACK map to VKEY_BROWSER_BACK (Closed)

Created:
5 years, 8 months ago by sky
Modified:
5 years, 8 months ago
CC:
aurimas (slooooooooow), chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes AKEYCODE_BACK map to VKEY_BROWSER_BACK Seems as though there is no reason for the old mapping, and browser_back makes more sense. R=jdduke@chromium.org Committed: https://crrev.com/825db4cd54f4aad434dd737b80e4349634589092 Cr-Commit-Position: refs/heads/master@{#325635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/events/keycodes/keyboard_code_conversion_android.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sky
5 years, 8 months ago (2015-04-16 23:11:53 UTC) #1
jdduke (slow)
lgtm. +aurimas to make sure I'm not missing some corner case here (Aurimas we intercept ...
5 years, 8 months ago (2015-04-16 23:34:16 UTC) #2
jdduke (slow)
(Oops, actually adding aurimas this time) +aurimas to make sure I'm not missing some corner ...
5 years, 8 months ago (2015-04-16 23:35:03 UTC) #3
aurimas (slooooooooow)
It seems reasonable to me. LGTM
5 years, 8 months ago (2015-04-16 23:38:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095483003/1
5 years, 8 months ago (2015-04-17 15:02:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 15:08:06 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 15:08:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/825db4cd54f4aad434dd737b80e4349634589092
Cr-Commit-Position: refs/heads/master@{#325635}

Powered by Google App Engine
This is Rietveld 408576698