Store hashes of current and previous shipped V8 version

tools/release/releases.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script retrieves the history of all V8 branches and
 # their corresponding Chromium revisions.
 
 # Requires a chromium checkout with branch heads:
 # gclient sync --with_branch_heads
@@ skipping 422 matching lines @@
       releases_dict.get(revision, {})["chromium_branch"] = ranges
 
 
 class RetrieveInformationOnChromeReleases(Step):
   MESSAGE = 'Retrieves relevant information on the latest Chrome releases'
 
   def Run(self):
 
     params = None
     result_raw = self.ReadURL(
                              "http://omahaproxy.appspot.com/all.json",

[Michael Achenbach, 2015/04/16 11:32:50]

Maybe make "http://omahaproxy.appspot.com/" a global constant.

                              params,
                              wait_plan=[5, 20]
                              )
     recent_releases = json.loads(result_raw)
 
     canaries = []
 
     for current_os in recent_releases:
       for current_version in current_os["versions"]:
+
+        if current_version["channel"] != "canary":
+          continue
+
+        url_to_call = "http://omahaproxy.appspot.com/v8.json?version=" + current_version["previous_version"]

[Michael Achenbach, 2015/04/16 11:32:50]

nit: 80 chars

+        result_raw = self.ReadURL(
+                             url_to_call,
+                             params,
+                             wait_plan=[5, 20]
+                             )
+        previous_v8_version_wrapper = json.loads(result_raw)

[Michael Achenbach, 2015/04/16 11:32:50]

inline local variable previous_v8_version_wrapper

[Michael Hablich, 2015/04/16 12:01:02]

What do you mean by that?

[Michael Achenbach, 2015/04/16 12:17:56]

I mean:
previous_v8_version = json.loads(result_raw)["v8_version"]

+        previous_v8_version = previous_v8_version_wrapper["v8_version"]
+        v8_previous_version_hash = self._GetGitHashForV8Version(previous_v8_version)
+
+        current_V8_version = current_version["v8_version"]

[Michael Achenbach, 2015/04/16 11:32:50]

nit: current_v8_version

[Michael Hablich, 2015/04/16 12:01:02]

Acknowledged.

+        v8_version_hash = self._GetGitHashForV8Version(current_V8_version)
+
         current_candidate = {
                             "chrome_version": current_version["version"],
-                           "os": current_version["os"],
-                           "release_date": current_version["current_reldate"],
-                           "v8_version": current_version["v8_version"],
+                            "os": current_version["os"],
+                            "release_date": current_version["current_reldate"],
+                            "v8_version": current_V8_version,
+                            "v8_version_hash": v8_version_hash,
+                            "v8_previous_version": previous_v8_version,
+                            "v8_previous_version_hash": v8_previous_version_hash,
                            }
 
-        if current_version["channel"] == "canary":
-          canaries.append(current_candidate)
+        canaries.append(current_candidate)
 
     chrome_releases = {"canaries": canaries}
     self["chrome_releases"] = chrome_releases
 
+  def _GetGitHashForV8Version(self, v8_version):
+    if v8_version.split(".")[3]== "0":
+        return self.GitGetHashOfTag(v8_version[:-2])

[Michael Achenbach, 2015/04/16 11:32:50]

nit: 2 space indentation + space before ==

[Michael Hablich, 2015/04/16 12:01:02]

Acknowledged.

+
+    return self.GitGetHashOfTag(v8_version)
+
 
 class CleanUp(Step):
   MESSAGE = "Clean up."
 
   def RunStep(self):
     self.CommonCleanup()
 
 
 class WriteOutput(Step):
   MESSAGE = "Print output."
@@ skipping 55 matching lines @@
       RetrieveChromiumV8Releases,
       RetrieveChromiumBranches,
       RetrieveInformationOnChromeReleases,
       CleanUp,
       WriteOutput,
     ]
 
 
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(Releases().Run())