Store hashes of current and previous shipped V8 version

Store hashes of current and previous shipped V8 version

Will be used for calculating changes between versions

BUG=
NOTRY=true

Committed: https://crrev.com/0bc1a1526f96c65b727e971e6ce092dcdf29b723
Cr-Commit-Position: refs/heads/master@{#27882}

[Michael Hablich, 2015-04-16 09:21:10]

hablich@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Hablich, 2015-04-16 09:49:23]

On 2015/04/16 09:21:10, Hablich wrote:
> mailto:hablich@chromium.org changed reviewers:
> + mailto:machenbach@chromium.org

PTAL

[Michael Achenbach, 2015-04-16 11:32:51]

lgtm with comments:

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:443: "http://omahaproxy.appspot.com/all.json",
Maybe make "http://omahaproxy.appspot.com/" a global constant.

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:457: url_to_call =
"http://omahaproxy.appspot.com/v8.json?version=" +
current_version["previous_version"]
nit: 80 chars

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:463: previous_v8_version_wrapper =
json.loads(result_raw)
inline local variable previous_v8_version_wrapper

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:467: current_V8_version =
current_version["v8_version"]
nit: current_v8_version

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:487: return self.GitGetHashOfTag(v8_version[:-2])
nit: 2 space indentation + space before ==

[Michael Hablich, 2015-04-16 12:01:02]

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:463: previous_v8_version_wrapper =
json.loads(result_raw)
On 2015/04/16 11:32:50, Michael Achenbach wrote:
> inline local variable previous_v8_version_wrapper

What do you mean by that?

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:467: current_V8_version =
current_version["v8_version"]
On 2015/04/16 11:32:50, Michael Achenbach wrote:
> nit: current_v8_version

Acknowledged.

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:487: return self.GitGetHashOfTag(v8_version[:-2])
On 2015/04/16 11:32:50, Michael Achenbach wrote:
> nit: 2 space indentation + space before ==

Acknowledged.

[Michael Achenbach, 2015-04-16 12:17:56]

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases.py
File tools/release/releases.py (right):

https://codereview.chromium.org/1095483002/diff/40001/tools/release/releases....
tools/release/releases.py:463: previous_v8_version_wrapper =
json.loads(result_raw)
On 2015/04/16 12:01:02, Hablich wrote:
> On 2015/04/16 11:32:50, Michael Achenbach wrote:
> > inline local variable previous_v8_version_wrapper
> 
> What do you mean by that?

I mean:
previous_v8_version = json.loads(result_raw)["v8_version"]

[Michael Hablich, 2015-04-16 12:48:35]

The CQ bit was checked by hablich@chromium.org

[Michael Hablich, 2015-04-16 12:48:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1095483002/#ps80001
(title: "Removed more than 80 character line")

[commit-bot: I haz the power, 2015-04-16 12:48:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1095483002/80001

[commit-bot: I haz the power, 2015-04-16 12:51:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-16 12:52:08]

Patchset 5 (id:??) landed as
https://crrev.com/0bc1a1526f96c65b727e971e6ce092dcdf29b723
Cr-Commit-Position: refs/heads/master@{#27882}