Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.cpp

Issue 1095433005: Force another diagnostic reporting path to be warn-only on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructsConsumer.cpp
diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp
index 4c40d52faae694983d4b18f5fdc8643bdf1eb6e7..2524550e6369bd1b13a2c6ec7e024179fc1070d7 100644
--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp
+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp
@@ -560,8 +560,8 @@ FindBadConstructsConsumer::CheckRecordForRefcountIssue(
// -Werror.
DiagnosticsEngine::Level FindBadConstructsConsumer::getErrorLevel() {
#if defined(LLVM_ON_WIN32)
- // Only warn on Windows, since there are a lot of potential pre-existing
- // issues.
+ // TODO(dcheng): Re-enable -Werror for these diagnostics on Windows once all
+ // the pre-existing warnings are cleaned up. https://crbug.com/467287
return DiagnosticsEngine::Warning;
#else
return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
« no previous file with comments | « tools/clang/plugins/ChromeClassTester.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698