Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1095393005: Changing Size to SizeOfObjects in GetHeapSpaceStatistics api. (Closed)

Created:
5 years, 8 months ago by ssid
Modified:
5 years, 8 months ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Changing Size to SizeOfObjects in GetHeapSpaceStatistics api. This CL changes GetHeapSpaceStatistics api to return SizeOfObjects() instead of Size(). SizeOfObjects is the required field and is consistent with GetHeapStatistics api. BUG=476013 LOG=N Committed: https://crrev.com/0be81a43eaf83e3b08143a8deb0115c7632c0e9f Cr-Commit-Position: refs/heads/master@{#28080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ssid
1 line change. PTAL. Thanks
5 years, 8 months ago (2015-04-24 14:33:24 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-27 13:28:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095393005/1
5 years, 8 months ago (2015-04-27 13:29:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 14:00:30 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 14:00:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0be81a43eaf83e3b08143a8deb0115c7632c0e9f
Cr-Commit-Position: refs/heads/master@{#28080}

Powered by Google App Engine
This is Rietveld 408576698