Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1095333004: GN Windows component build fixes: media (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN Windows component build fixes: media CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg TBR=dpranke@chromium.org Committed: https://crrev.com/d0fb9257273686f0dc5c942bf678075f28349dd0 Cr-Commit-Position: refs/heads/master@{#326916}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -47 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/BUILD.gn View 8 chunks +24 lines, -12 lines 1 comment Download
M media/audio/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M media/base/BUILD.gn View 8 chunks +53 lines, -31 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
brettw
The component build patch is causing too many problems so I'm splitting it apart. Carrying ...
5 years, 8 months ago (2015-04-24 21:45:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095333004/1
5 years, 8 months ago (2015-04-24 21:46:09 UTC) #3
Dirk Pranke
lgtm https://codereview.chromium.org/1095333004/diff/1/media/BUILD.gn File media/BUILD.gn (right): https://codereview.chromium.org/1095333004/diff/1/media/BUILD.gn#newcode361 media/BUILD.gn:361: allow_circular_includes_from = [ "//media/base/android" ] ick :(.
5 years, 8 months ago (2015-04-24 21:54:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 22:55:39 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 22:56:25 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d0fb9257273686f0dc5c942bf678075f28349dd0
Cr-Commit-Position: refs/heads/master@{#326916}

Powered by Google App Engine
This is Rietveld 408576698