Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 109533003: HTMLOptionElement code style: consistently access select owner. (Closed)

Created:
7 years ago by sof
Modified:
7 years ago
Reviewers:
tkent, adamk
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

HTMLOptionElement code style: consistently access select owner. For methods that access the select owner, do this consistently when otherwise possible. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164189

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/core/html/HTMLOptionElement.cpp View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Please take a look. Belatedly following up on a style issue raised in https://codereview.chromium.org/102263006/#msg5
7 years ago (2013-12-19 11:04:05 UTC) #1
adamk
lgtm
7 years ago (2013-12-19 16:07:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/109533003/1
7 years ago (2013-12-19 16:07:21 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-19 17:18:42 UTC) #4
Message was sent while issue was closed.
Change committed as 164189

Powered by Google App Engine
This is Rietveld 408576698