Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1095313002: [turbofan] Fix reduction of LoadProperty/StoreProperty to LoadNamed/StoreNamed. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix reduction of LoadProperty/StoreProperty to LoadNamed/StoreNamed. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/1850803d56d6da94adf1f3ac779e5e9ea2388333 Cr-Commit-Position: refs/heads/master@{#27972}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -16 lines) Patch
M src/compiler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/js-operator.h View 3 chunks +23 lines, -7 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/js-type-feedback.cc View 3 chunks +10 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/named-load.js View 1 1 chunk +31 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/named-store.js View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 8 months ago (2015-04-21 13:17:55 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1095313002/diff/1/test/mjsunit/compiler/load-named.js File test/mjsunit/compiler/load-named.js (right): https://codereview.chromium.org/1095313002/diff/1/test/mjsunit/compiler/load-named.js#newcode3 test/mjsunit/compiler/load-named.js:3: // found in the LICENSE file. suggestion: Maybe ...
5 years, 8 months ago (2015-04-21 14:04:34 UTC) #2
titzer
On 2015/04/21 14:04:34, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/1095313002/diff/1/test/mjsunit/compiler/load-named.js > File test/mjsunit/compiler/load-named.js (right): ...
5 years, 8 months ago (2015-04-21 14:21:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095313002/20001
5 years, 8 months ago (2015-04-21 14:22:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 15:13:18 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:10:21 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1850803d56d6da94adf1f3ac779e5e9ea2388333
Cr-Commit-Position: refs/heads/master@{#27972}

Powered by Google App Engine
This is Rietveld 408576698