Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1095293007: Restrict __qem usage to UA sheets (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/css3/supports-dom-api-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 96dffc7295543f0d1fcc1c1ffffd2c87c9d34458..778f7231902a33592f5e7975dfa2b9ddbe7095c3 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -247,8 +247,10 @@ bool CSSPropertyParser::validUnit(CSSParserValue* value, Units unitflags, CSSPar
return false;
case CSSPrimitiveValue::CSS_PERCENTAGE:
return unitflags & FPercent;
- // TODO(timloh): Restrict usage of __qem to UA sheets
case CSSParserValue::Q_EMS:
+ if (cssParserMode != UASheetMode)
+ return false;
+ /* fallthrough intentional */
case CSSPrimitiveValue::CSS_EMS:
case CSSPrimitiveValue::CSS_REMS:
case CSSPrimitiveValue::CSS_CHS:
« no previous file with comments | « LayoutTests/css3/supports-dom-api-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698