Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1095203006: [iOS] Upstream XCallbackParameters (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
jif
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream XCallbackParameters XCallbackParameters holds the information about an x-callback request from another application. BUG=429756 Committed: https://crrev.com/9816d5ee8bd97ac1a9432209342d9cf02fba3c3e Cr-Commit-Position: refs/heads/master@{#326793}

Patch Set 1 #

Patch Set 2 : Remove unused #include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
A ios/chrome/browser/xcallback_parameters.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/chrome/browser/xcallback_parameters.mm View 1 1 chunk +94 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095203006/1
5 years, 8 months ago (2015-04-24 13:11:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095203006/20001
5 years, 8 months ago (2015-04-24 13:13:13 UTC) #4
sdefresne
PTAL
5 years, 8 months ago (2015-04-24 13:19:06 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-24 13:32:30 UTC) #8
jif
lgtm
5 years, 8 months ago (2015-04-24 14:42:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095203006/20001
5 years, 8 months ago (2015-04-24 14:42:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 14:43:41 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 14:45:06 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9816d5ee8bd97ac1a9432209342d9cf02fba3c3e
Cr-Commit-Position: refs/heads/master@{#326793}

Powered by Google App Engine
This is Rietveld 408576698