Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 1095203005: Fix stack layout of full code arm64 for object literal. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/lazy-deopt-in-literal.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1722 matching lines...) Expand 10 before | Expand all | Expand 10 after
1733 __ Mov(StoreDescriptor::NameRegister(), 1733 __ Mov(StoreDescriptor::NameRegister(),
1734 Operand(isolate()->factory()->home_object_symbol())); 1734 Operand(isolate()->factory()->home_object_symbol()));
1735 __ Peek(StoreDescriptor::ValueRegister(), 0); 1735 __ Peek(StoreDescriptor::ValueRegister(), 0);
1736 CallStoreIC(); 1736 CallStoreIC();
1737 } 1737 }
1738 } else { 1738 } else {
1739 VisitForEffect(value); 1739 VisitForEffect(value);
1740 } 1740 }
1741 break; 1741 break;
1742 } 1742 }
1743 __ Peek(x0, 0);
1744 __ Push(x0);
1745 VisitForStackValue(key);
1746 VisitForStackValue(value);
1743 if (property->emit_store()) { 1747 if (property->emit_store()) {
1744 // Duplicate receiver on stack.
1745 __ Peek(x0, 0);
1746 __ Push(x0);
1747 VisitForStackValue(key);
1748 VisitForStackValue(value);
1749 EmitSetHomeObjectIfNeeded(value, 2); 1748 EmitSetHomeObjectIfNeeded(value, 2);
1750 __ Mov(x0, Smi::FromInt(SLOPPY)); // Language mode 1749 __ Mov(x0, Smi::FromInt(SLOPPY)); // Language mode
1751 __ Push(x0); 1750 __ Push(x0);
1752 __ CallRuntime(Runtime::kSetProperty, 4); 1751 __ CallRuntime(Runtime::kSetProperty, 4);
1753 } else { 1752 } else {
1754 VisitForEffect(key); 1753 __ Drop(3);
1755 VisitForEffect(value);
1756 } 1754 }
1757 break; 1755 break;
1758 case ObjectLiteral::Property::PROTOTYPE: 1756 case ObjectLiteral::Property::PROTOTYPE:
1759 DCHECK(property->emit_store()); 1757 DCHECK(property->emit_store());
1760 // Duplicate receiver on stack. 1758 // Duplicate receiver on stack.
1761 __ Peek(x0, 0); 1759 __ Peek(x0, 0);
1762 __ Push(x0); 1760 __ Push(x0);
1763 VisitForStackValue(value); 1761 VisitForStackValue(value);
1764 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1762 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1765 break; 1763 break;
(...skipping 3742 matching lines...) Expand 10 before | Expand all | Expand 10 after
5508 } 5506 }
5509 } 5507 }
5510 5508
5511 return INTERRUPT; 5509 return INTERRUPT;
5512 } 5510 }
5513 5511
5514 5512
5515 } } // namespace v8::internal 5513 } } // namespace v8::internal
5516 5514
5517 #endif // V8_TARGET_ARCH_ARM64 5515 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/compiler/lazy-deopt-in-literal.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698