[MIPS] Add support in media.gyp for building on MIPS architecture.

[MIPS] Add support in media.gyp for building on MIPS architecture.

Small change in media.gyp to support building for MIPS arch.

BUG=130022
TEST=make chrome

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157697

[petarj, 2012-09-18 19:35:24]

Here is a small change in:

- media/media.gyp and
- media/base/yuv_convert.cc

that adds support to support for building for MIPS arch.

[scherkus (not reviewing), 2012-09-19 16:57:54]

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc
File media/base/yuv_convert.cc (right):

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc#newc...
media/base/yuv_convert.cc:446: #if defined(ARCH_CPU_ARM_FAMILY)
instead of #elif can you use "|| defined(ARCH_CPU_MIPS_FAMILY)" + update the
comment?

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc#newc...
media/base/yuv_convert.cc:478: ConvertRGB24ToYUV_C(rgbframe, yplane, uplane,
vplane, width, height,
ditto

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc#newc...
media/base/yuv_convert.cc:552: ConvertYUVToRGB32_C(yplane, uplane, vplane,
rgbframe,
ditto

http://codereview.chromium.org/10952006/diff/1/media/media.gyp
File media/media.gyp (right):

http://codereview.chromium.org/10952006/diff/1/media/media.gyp#newcode807
media/media.gyp:807: [ 'target_arch == "arm"', {
this can be:
target_arch == "arm" or target_arch == "mipsel"

see my comment below about de-duplicating

http://codereview.chromium.org/10952006/diff/1/media/media.gyp#newcode937
media/media.gyp:937: 'target_name': 'yuv_convert_simd_arm',
instead of duplicating, you should rename this to "yuv_convert_simd_c" and
change the condition at the top to include arm OR mips

[petarj, 2012-09-20 00:18:24]

The patch has been changed per code review comments.

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc
File media/base/yuv_convert.cc (right):

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc#newc...
media/base/yuv_convert.cc:446: #if defined(ARCH_CPU_ARM_FAMILY)
On 2012/09/19 16:57:54, scherkus wrote:
> instead of #elif can you use "|| defined(ARCH_CPU_MIPS_FAMILY)" + update the
> comment?

Done.

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc#newc...
media/base/yuv_convert.cc:478: ConvertRGB24ToYUV_C(rgbframe, yplane, uplane,
vplane, width, height,
On 2012/09/19 16:57:54, scherkus wrote:
> ditto

Done.

http://codereview.chromium.org/10952006/diff/1/media/base/yuv_convert.cc#newc...
media/base/yuv_convert.cc:552: ConvertYUVToRGB32_C(yplane, uplane, vplane,
rgbframe,
On 2012/09/19 16:57:54, scherkus wrote:
> ditto

Done.

http://codereview.chromium.org/10952006/diff/1/media/media.gyp
File media/media.gyp (right):

http://codereview.chromium.org/10952006/diff/1/media/media.gyp#newcode807
media/media.gyp:807: [ 'target_arch == "arm"', {
On 2012/09/19 16:57:54, scherkus wrote:
> this can be:
> target_arch == "arm" or target_arch == "mipsel"
> 
> see my comment below about de-duplicating

Done.

http://codereview.chromium.org/10952006/diff/1/media/media.gyp#newcode937
media/media.gyp:937: 'target_name': 'yuv_convert_simd_arm',
On 2012/09/19 16:57:54, scherkus wrote:
> instead of duplicating, you should rename this to "yuv_convert_simd_c" and
> change the condition at the top to include arm OR mips

Done.

[scherkus (not reviewing), 2012-09-20 00:22:03]

lgtm

thanks!

[commit-bot: I haz the power, 2012-09-20 00:25:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/petarj@mips.com/10952006/5002

[commit-bot: I haz the power, 2012-09-20 03:33:40]

Change committed as 157697