Issue 1095183003: mojom.gni: add a source set called ${target_name}_cpp_sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1095183003: mojom.gni: add a source set called ${target_name}_cpp_sources. (Closed)

Created:
5 years, 8 months ago by yzshen1

Modified:
5 years, 8 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

mojom.gni: add a source set called ${target_name}_cpp_sources. BUG=None TEST=None

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	mojo/public/tools/bindings/mojom.gni	View		4 chunks	+24 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

The other sourcesets are called things like foo_java, foo_dart, etc. why not foo_cpp ?

5 years, 8 months ago (2015-04-20 22:52:07 UTC) #3

yzshen1

On 2015/04/20 22:52:07, jamesr wrote: > The other sourcesets are called things like foo_java, foo_dart, ...

5 years, 8 months ago (2015-04-21 15:51:47 UTC) #4

yzshen1

5 years, 8 months ago (2015-04-21 18:47:39 UTC) #6

Message was sent while issue was closed.

On 2015/04/21 17:07:56, jamesr wrote:
> Hmm, ok. lgtm

Committed but somehow the commit info didn't show up here.

The commit ID is 80ecbfdedd8ce9c2da6391c270ac92281c39e199

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages