Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1095163004: Disabling handle verifier till we figure out AppContainer/DuplicateHandle errors. (Closed)

Created:
5 years, 8 months ago by Shrikant Kelkar
Modified:
5 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, wfh+watch_chromium.org, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling handle verifier till we figure out AppContainer/DuplicateHandle errors. When we launch renderer using AppContainer sometimes DuplicateFrom (DuplicateHandle) is failing in TargetProcess::Create(). As this tracker is part of DuplicateFrom, it may be masking actual error code returned by DuplicateHandle(). BUG=467920, 472362 R=cpu@chromium.org Committed: https://crrev.com/8d9201fbdbdced060982ec96b51c93d6347b8a5c Cr-Commit-Position: refs/heads/master@{#326099}

Patch Set 1 #

Patch Set 2 : Replaced DisableHandleVerifier with Disable method to resolve compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/win/scoped_handle.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Shrikant Kelkar
5 years, 8 months ago (2015-04-21 01:21:41 UTC) #1
cpu_(ooo_6.6-7.5)
Is that the right bug number? I was expecting the other bug number, the one ...
5 years, 8 months ago (2015-04-21 15:34:20 UTC) #2
cpu_(ooo_6.6-7.5)
or I guess both bugs.
5 years, 8 months ago (2015-04-21 15:34:34 UTC) #3
Shrikant Kelkar
On 2015/04/21 15:34:34, cpu_OOO_13th_17th_week wrote: > or I guess both bugs. Sorry didn't get which ...
5 years, 8 months ago (2015-04-21 17:12:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095163004/1
5 years, 8 months ago (2015-04-21 17:12:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/75697)
5 years, 8 months ago (2015-04-21 18:19:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095163004/20001
5 years, 8 months ago (2015-04-21 18:35:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 19:39:10 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 19:41:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d9201fbdbdced060982ec96b51c93d6347b8a5c
Cr-Commit-Position: refs/heads/master@{#326099}

Powered by Google App Engine
This is Rietveld 408576698