Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 109513002: make tests output spin on the same line by default (Closed)

Created:
7 years ago by mtklein
Modified:
6 years, 11 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make tests output spin on the same line by default. -v now gives a cleaned-up version of the existing output (every test timed, useless information removed) Example output, default: [ 36/193] PathOpsCubicIntersectionOneOffTest then later when finished... [193/193] BlurMaskFilter Example output, -v: (note, codereview is messing up my pretty spacing) Skia UnitTests: --resourcePath resources SK_RELEASE SK_SCALAR_IS_FLOAT skia_arch_width=32 [ 1/193] 0ms PathOpsSimplifyDontFailOneTest [ 2/193] 0ms PathOpsSimplifyFailOneTest [ 3/193] 30ms PathOpsSkpTest [ 4/193] 21ms PathOpsSimplifyFailTest .... [182/193] 1026ms BlitRow [183/193] 808ms AAClip [184/193] 4333ms Math [185/193] 5068ms PackBits [186/193] 2265ms DrawText_DrawPosText [187/193] 9163ms PathOpsRectsThreadedTest [188/193] 5540ms GLPrograms [189/193] 0ms GLInterfaceValidation [190/193] 2ms DeferredCanvas [191/193] 1ms ClipCache [192/193] 30ms BlurMaskFilter [193/193] 10396ms PathOpsOpCubicsThreadedTest Finished 193 tests, 0 failures, 0 skipped. (622610 internal tests) BUG= Committed: http://code.google.com/p/skia/source/detail?r=12860

Patch Set 1 #

Patch Set 2 : simplify #

Patch Set 3 : split windows and other for line overwriting #

Patch Set 4 : 79 #

Patch Set 5 : rebase #

Patch Set 6 : more refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -91 lines) Patch
M dm/DMReporter.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M gyp/dm.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tests/skia_test.cpp View 1 2 3 4 5 6 chunks +48 lines, -90 lines 0 comments Download
A tools/OverwriteLine.h View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
mtklein
7 years ago (2013-12-10 16:05:21 UTC) #1
hal.canary
lgtm
7 years ago (2013-12-10 22:03:43 UTC) #2
mtklein
On 2013/12/10 16:05:21, mtklein wrote: please have another look
7 years ago (2013-12-10 22:03:47 UTC) #3
mtklein
On 2013/12/10 22:03:47, mtklein wrote: > On 2013/12/10 16:05:21, mtklein wrote: > > please have ...
7 years ago (2013-12-10 22:03:57 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-10 22:04:22 UTC) #5
mtklein
On 2013/12/10 22:04:22, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years ago (2013-12-10 22:05:40 UTC) #6
mtklein
On 2013/12/10 22:05:40, mtklein wrote: > On 2013/12/10 22:04:22, I haz the power (commit-bot) wrote: ...
7 years ago (2013-12-10 22:05:50 UTC) #7
mtklein
On 2013/12/10 22:05:50, mtklein wrote: > On 2013/12/10 22:05:40, mtklein wrote: > > On 2013/12/10 ...
7 years ago (2013-12-10 22:06:15 UTC) #8
mtklein
On 2013/12/10 22:06:15, mtklein wrote: > On 2013/12/10 22:05:50, mtklein wrote: > > On 2013/12/10 ...
7 years ago (2013-12-10 22:06:25 UTC) #9
mtklein
On 2013/12/10 22:06:25, mtklein wrote: > On 2013/12/10 22:06:15, mtklein wrote: > > On 2013/12/10 ...
7 years ago (2013-12-10 22:06:51 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-10 22:07:22 UTC) #11
bungeman-skia
You mean like https://github.com/martine/ninja/blob/master/src/line_printer.cc
7 years ago (2013-12-10 22:30:26 UTC) #12
mtklein
On 2013/12/10 22:30:26, bungeman1 wrote: > You mean like > > https://github.com/martine/ninja/blob/master/src/line_printer.cc Heck no, too ...
7 years ago (2013-12-10 22:55:56 UTC) #13
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-11 20:24:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/109513002/90001
6 years, 11 months ago (2014-01-02 16:07:51 UTC) #15
commit-bot: I haz the power
6 years, 11 months ago (2014-01-02 16:19:57 UTC) #16
Message was sent while issue was closed.
Change committed as 12860

Powered by Google App Engine
This is Rietveld 408576698