Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: tests/language/is_interfaces2_test.dart

Issue 10951026: Fix algorithm to know whether we should emit an is check on a class: all interfaces/implemented cla… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/js_backend/emitter.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/is_interfaces2_test.dart
===================================================================
--- tests/language/is_interfaces2_test.dart (revision 12536)
+++ tests/language/is_interfaces2_test.dart (working copy)
@@ -8,26 +8,38 @@
class B extends A {
}
-class C implements B {
+class C extends B {
}
-int inscrutable(int x) => x == 0 ? 0 : x | inscrutable(x & (x - 1));
+class D implements C {
+}
+int inscrutable(int x) => (x == 0) ? 0 : (x | inscrutable(x & (x - 1)));
+
main() {
- var things = [new A(), new B(), new C()];
+ var things = [new A(), new B(), new C(), new D()];
var a = things[inscrutable(0)];
Expect.isTrue(a is A);
Expect.isFalse(a is B);
Expect.isFalse(a is C);
+ Expect.isFalse(a is D);
var b = things[inscrutable(1)];
Expect.isTrue(b is A);
Expect.isTrue(b is B);
Expect.isFalse(b is C);
+ Expect.isFalse(b is D);
var c = things[inscrutable(2)];
Expect.isTrue(c is A);
Expect.isTrue(c is B);
Expect.isTrue(c is C);
+ Expect.isFalse(c is D);
+
+ var d = things[inscrutable(3)];
+ Expect.isTrue(d is A);
+ Expect.isTrue(d is B);
+ Expect.isTrue(d is C);
+ Expect.isTrue(d is D);
}
« no previous file with comments | « lib/compiler/implementation/js_backend/emitter.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698