Issue 10951023: Update page icon in the omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10951023: Update page icon in the omnibox (Closed)

Created:
8 years, 3 months ago by Nico

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, James Su, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update page icon in the omnibox The location bar and the omnibox popup currently show an "empty page" icon for http entries. This CL makes it so that the asset in the location bar is different from the one in the popup, and updates the asset used in both places. BUG=149903 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157549

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, --3 lines)			Patch
A	chrome/app/theme/default_100_percent/common/location_bar_http.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/default_100_percent/common/omnibox_http.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/default_100_percent/common/omnibox_http_selected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/default_200_percent/common/location_bar_http.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/default_200_percent/common/omnibox_http.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/default_200_percent/common/omnibox_http_selected.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_match.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/omnibox/omnibox_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/toolbar/toolbar_model.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages