Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: pkg/unittest/html_enhanced_config.dart

Issue 10951015: Issue 5152: Browser bots much more flaky after going "wrapperless" (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/unittest/html_enhanced_config.dart
===================================================================
--- pkg/unittest/html_enhanced_config.dart (revision 12507)
+++ pkg/unittest/html_enhanced_config.dart (working copy)
@@ -21,6 +21,7 @@
// TODO(rnystrom): Get rid of this if we get canonical closures for methods.
EventListener _onErrorClosure;
+ EventListener _onMessageClosure;
void onInit() {
//initialize and load CSS
@@ -37,12 +38,18 @@
_onErrorClosure =
(e) => handleExternalError(e, '(DOM callback has errors)');
+ _onMessageClosure = (m) {
+ if (m.data == 'unittest-suite-external-error') {
+ handleExternalError('<unknown>', '(external error detected)');
+ }
+ };
}
void onStart() {
window.postMessage('unittest-suite-wait-for-done', '*');
// Listen for uncaught errors.
window.on.error.add(_onErrorClosure);
+ window.on.error.add(_onMessageClosure);
}
void onTestResult(TestCase testCase) {}
@@ -50,6 +57,7 @@
void onDone(int passed, int failed, int errors, List<TestCase> results,
String uncaughtError) {
window.on.error.remove(_onErrorClosure);
+ window.on.error.remove(_onMessageClosure);
_showInteractiveResultsInPage(passed, failed, errors, results,
_isLayoutTest, uncaughtError);

Powered by Google App Engine
This is Rietveld 408576698