public/platform/modules/notifications/WebNotificationData.h - Issue 1095093002: Add layouttest for notification properties of persistent notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/modules/notifications/WebNotificationData.h

Issue 1095093002: Add layouttest for notification properties of persistent notification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html ('K') | « LayoutTests/http/tests/notifications/serviceworkerregistration-document-data-throw.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/modules/notifications/WebNotificationData.h

diff --git a/public/platform/modules/notifications/WebNotificationData.h b/public/platform/modules/notifications/WebNotificationData.h

index dbcf45a4dac8857e8a1fbb695964982187df9aca..75b2575bc93323c4a40354845645166bae443c01 100644

--- a/public/platform/modules/notifications/WebNotificationData.h

+++ b/public/platform/modules/notifications/WebNotificationData.h

@@ -24,19 +24,6 @@ struct WebNotificationData {

{

}

- // FIXME: Remove this constructor when Chromium has switched to the new one.

- WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, bool silent, const WebVector<char>& data)

- : title(title)

- , direction(direction)

- , lang(lang)

- , body(body)

- , tag(tag)

- , icon(icon)

- , silent(silent)

- , data(data)

- {

- }

WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, const WebVector<int>& vibrate, bool silent, const WebVector<char>& data)

: title(title)

, direction(direction)