Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

Issue 1095093002: Add layouttest for notification properties of persistent notification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
diff --git a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
index 577c4c5eacffbc6a52e53e91c626e9b24c06eb87..5bf4edf0021dd04b5f0c9be24ecb87ab4db69e2d 100644
--- a/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
+++ b/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html
@@ -26,7 +26,8 @@
// FIXME: Relative URLs for the icon attribute currently get reflected as
// an absolute URL, which should probably be the given relative URL.
icon: 'https://example/icon.png',
- silent: true,
+ vibrate: [100, 200, 300],
+ silent: false,
data: [
{ property: 'foobar',
string: '\uDFFF\u0000\uDBFF',
@@ -65,14 +66,9 @@
assert_equals(event.data.command, 'click', 'The notification was expected to be clicked.');
Object.keys(options).forEach(function(key) {
- if (key == 'data')
- return; // Check "data" separately to avoid stringifying it.
-
- assert_equals(event.data.notification[key], options[key], 'The ' + key + ' field must be the same.');
+ assert_object_equals(event.data.notification[key], options[key], 'The ' + key + ' field must be the same.');
});
- assert_object_equals(event.data.notification.data, options.data, 'The data field must be the same.');
-
test.done();
});
}).catch(unreached_rejection(test));

Powered by Google App Engine
This is Rietveld 408576698