chrome/browser/download/download_target_determiner.cc - Issue 1095083003: Ensure that by default PDFs are opened in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_target_determiner.cc

Issue 1095083003: Ensure that by default PDFs are opened in Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_target_determiner.cc

diff --git a/chrome/browser/download/download_target_determiner.cc b/chrome/browser/download/download_target_determiner.cc

index ee41e0a08880c5fb1f3cfcffb4d6db6140d4656b..f1f6e652c889f43775b5c82e7b1df1b124b10f88 100644

--- a/chrome/browser/download/download_target_determiner.cc

+++ b/chrome/browser/download/download_target_determiner.cc

@@ -461,7 +461,8 @@ void IsHandledBySafePlugin(content::ResourceContext* resource_context,

bool is_handled_safely =

plugin_found &&

(plugin_info.type == WebPluginInfo::PLUGIN_TYPE_PEPPER_IN_PROCESS ||

- plugin_info.type == WebPluginInfo::PLUGIN_TYPE_PEPPER_OUT_OF_PROCESS);

+ plugin_info.type == WebPluginInfo::PLUGIN_TYPE_PEPPER_OUT_OF_PROCESS ||

+ plugin_info.type == WebPluginInfo::PLUGIN_TYPE_BROWSER_PLUGIN);

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE, base::Bind(callback, is_handled_safely));

}

« no previous file with comments | « no previous file | chrome/browser/download/download_target_determiner_unittest.cc » ('j') | no next file with comments »