Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1095083002: Allow for accessing an ArrayBuffer contents without externalizing it (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow for accessing an ArrayBuffer contents without externalizing it The embedder has to take appropriate steps to ensure that the ArrayBuffer doesn't die while it's accessing the pointer, e.g. keep a Local handle to it around BUG=none R=dslomov@chromium.org LOG=y Committed: https://crrev.com/ad854ea11e787a673a40b7917a955bee6d7dc253 Cr-Commit-Position: refs/heads/master@{#27942}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M include/v8.h View 1 3 chunks +20 lines, -3 lines 0 comments Download
M src/api.cc View 1 2 chunks +16 lines, -8 lines 0 comments Download
M test/cctest/test-typedarrays.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-20 12:23:54 UTC) #1
dcarney
lgtm https://codereview.chromium.org/1095083002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1095083002/diff/1/include/v8.h#newcode3434 include/v8.h:3434: size_t byte_length, bool is_external = true); no bool ...
5 years, 8 months ago (2015-04-20 13:19:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095083002/20001
5 years, 8 months ago (2015-04-20 13:33:04 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-20 15:01:59 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 15:02:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad854ea11e787a673a40b7917a955bee6d7dc253
Cr-Commit-Position: refs/heads/master@{#27942}

Powered by Google App Engine
This is Rietveld 408576698