Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1095043003: Convert LayoutObject renderer names. (Closed)

Created:
5 years, 8 months ago by dsinclair
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, dglazkov+blink, Dominik Röttsches, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, slimming-paint-reviews_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Convert LayoutObject renderer names. This CL converts the use of renderer to layoutObject in the LayoutObject class. BUG=462960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194430

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -164 lines) Patch
M Source/core/dom/DocumentLifecycle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFullScreen.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutListItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMenuList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 22 chunks +60 lines, -60 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 36 chunks +81 lines, -81 lines 0 comments Download
M Source/core/layout/LayoutView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/SubtreeLayoutScope.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/SubtreeLayoutScope.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/paint/ViewPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dsinclair
PTAL.
5 years, 8 months ago (2015-04-24 15:30:07 UTC) #2
leviw_travelin_and_unemployed
LGTM. For some reason I thought we'd done SubtreeLayoutScope before...
5 years, 8 months ago (2015-04-24 18:51:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095043003/20001
5 years, 8 months ago (2015-04-25 00:45:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/32095)
5 years, 8 months ago (2015-04-25 00:52:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095043003/40001
5 years, 8 months ago (2015-04-25 01:03:19 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 16:26:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194430

Powered by Google App Engine
This is Rietveld 408576698