Fix queued writes in DeviceSettingsProvider.

Fix queued writes in DeviceSettingsProvider.

The check for pending operations was bad, which would lead to pending changes accumulating. Props to pastarmovj for debugging this and proposing the fix.

BUG=chromium:149983
TEST=unit tests, see bug report.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157961

[Mattias Nissler (ping if slow), 2012-09-19 17:48:21]

Julian, your CL was actually exactly correct, the check should have been only on
the DeviceSettingsUpdated() call site. I've also written a test that catches
this.

[pastarmovj, 2012-09-20 08:30:07]

LGTM with a nit on the test.

http://codereview.chromium.org/10950032/diff/1/chrome/browser/chromeos/settin...
File chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
(right):

http://codereview.chromium.org/10950032/diff/1/chrome/browser/chromeos/settin...
chrome/browser/chromeos/settings/device_settings_provider_unittest.cc:213:
EXPECT_CALL(*this, SettingChanged(_)).Times(AnyNumber());
If you expect any number why do you have this line twice? I guess this is meant
to be Times(2) in a single line?

[Mattias Nissler (ping if slow), 2012-09-20 09:47:01]

https://codereview.chromium.org/10950032/diff/1/chrome/browser/chromeos/setti...
File chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
(right):

https://codereview.chromium.org/10950032/diff/1/chrome/browser/chromeos/setti...
chrome/browser/chromeos/settings/device_settings_provider_unittest.cc:213:
EXPECT_CALL(*this, SettingChanged(_)).Times(AnyNumber());
On 2012/09/20 08:30:07, pastarmovj wrote:
> If you expect any number why do you have this line twice? I guess this is
meant
> to be Times(2) in a single line?

I intended to have only one line :) Fixed.

I don't think we should force exactly two updates, I think either behavior (one
or two or many updates) are fine.

[commit-bot: I haz the power, 2012-09-20 09:47:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/10950032/6001

[commit-bot: I haz the power, 2012-09-20 18:39:07]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is HEAD

[commit-bot: I haz the power, 2012-09-20 22:17:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/10950032/6001

[commit-bot: I haz the power, 2012-09-20 23:41:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-21 07:05:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/10950032/6001