Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1095003002: [tracing] Simplify design of MemoryAllocatorDump (Closed)

Created:
5 years, 8 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 8 months ago
Reviewers:
nduca
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@matr_2_sess
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Simplify design of MemoryAllocatorDump This is a follow-up to crrev.com/1084213003 (which introduces the MemoryAllocatorAttributesTypes) and crrev.com/1093953002 (which introduces the shared MemoryDumpSessionState). The design of MemoryAllocatorDump is simplified, as follows: MemoryAllocatorDump(s) are uniquely identified witin a ProcessMemoryDump by an allocator_name and a heap_name. The former acts as a type, and determines the types of the attributes. The latter defines the rest of the dump name. As far as the trace is concerned, the allocator dumps will be identified the trace by an absolute path, that is: allocator_name/heap/subheap. BUG=466141 Committed: https://crrev.com/ba8859465a0ff1a6b9eb63f9ed5d4cd8bba69cfb Cr-Commit-Position: refs/heads/master@{#325994}

Patch Set 1 #

Patch Set 2 : Fix kRootHeap #

Patch Set 3 : rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -169 lines) Patch
M base/trace_event/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/malloc_dump_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D base/trace_event/memory_allocator_attributes.h View 1 chunk +0 lines, -29 lines 0 comments Download
M base/trace_event/memory_allocator_dump.h View 1 2 3 1 chunk +54 lines, -16 lines 0 comments Download
M base/trace_event/memory_allocator_dump.cc View 1 2 3 2 chunks +54 lines, -33 lines 0 comments Download
M base/trace_event/memory_allocator_dump_unittest.cc View 1 2 3 1 chunk +68 lines, -48 lines 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 2 3 3 chunks +37 lines, -1 line 0 comments Download
M base/trace_event/memory_dump_provider.h View 1 2 3 3 chunks +11 lines, -9 lines 0 comments Download
M base/trace_event/memory_dump_provider.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M base/trace_event/memory_dump_session_state.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/process_memory_dump.h View 2 chunks +22 lines, -10 lines 0 comments Download
M base/trace_event/process_memory_dump.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M base/trace_event/trace_event.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Primiano Tucci (use gerrit)
PTAL, This is a set of 3 CLs: crrev.com/1084213003: Introduce the MemoryAllocatorAttributesTypes crrev.com/1093953002: Introduce the ...
5 years, 8 months ago (2015-04-18 18:56:10 UTC) #2
nduca
lgtm
5 years, 8 months ago (2015-04-19 18:01:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095003002/60001
5 years, 8 months ago (2015-04-21 06:10:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095003002/60001
5 years, 8 months ago (2015-04-21 06:12:50 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-21 07:08:25 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 07:09:17 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ba8859465a0ff1a6b9eb63f9ed5d4cd8bba69cfb
Cr-Commit-Position: refs/heads/master@{#325994}

Powered by Google App Engine
This is Rietveld 408576698