Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: test/runner/browser/chrome_test.dart

Issue 1094993002: Fix tests and analysis warnings and release 0.12.0-beta.9. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pubspec.yaml ('k') | test/runner/browser/content_shell_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/browser/chrome_test.dart
diff --git a/test/runner/browser/chrome_test.dart b/test/runner/browser/chrome_test.dart
index 25b86b32e9282b0fb4e0b743e4bdbda22935751b..6e2275d76ad7e3ea864f76a6cbc786c9641ec9a5 100644
--- a/test/runner/browser/chrome_test.dart
+++ b/test/runner/browser/chrome_test.dart
@@ -14,6 +14,8 @@ import 'package:shelf/shelf.dart' as shelf;
import 'package:shelf/shelf_io.dart' as shelf_io;
import 'package:shelf_web_socket/shelf_web_socket.dart';
+import '../../utils.dart';
+
void main() {
group("running JavaScript", () {
// The JavaScript to serve in the server. We use actual JavaScript here to
@@ -80,7 +82,10 @@ webSocket.addEventListener("open", function() {
return webSocket.first.then(
(message) => expect(message, equals("loaded!")));
}).whenComplete(chrome.close);
- });
+ },
+ // It's not clear why, but this test in particular seems to time out
+ // when run in parallel with many other tests.
+ timeout: new Timeout.factor(2));
test("doesn't preserve state across runs", () {
javaScript = '''
@@ -135,6 +140,7 @@ webSocket.addEventListener("open", function() {
test("reports an error in onExit", () {
var chrome = new Chrome("http://dart-lang.org",
executable: "_does_not_exist");
- expect(chrome.onExit, throwsA(new isInstanceOf<ProcessException>()));
+ expect(chrome.onExit, throwsA(isApplicationException(startsWith(
+ "Failed to start Chrome: No such file or directory"))));
});
}
« no previous file with comments | « pubspec.yaml ('k') | test/runner/browser/content_shell_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698