net/cert/cert_verify_proc.h - Issue 1094983002: Account for the OS returning an empty certificate chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc.h

Issue 1094983002: Account for the OS returning an empty certificate chain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test, somewhat tidier code Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_verify_proc.h

diff --git a/net/cert/cert_verify_proc.h b/net/cert/cert_verify_proc.h

index f60ed6d9232631f1ae2e0fcefb27a373bfe20d08..3cea884bc62b2c67c444033fb93eae2de88ca0fc 100644

--- a/net/cert/cert_verify_proc.h

+++ b/net/cert/cert_verify_proc.h

@@ -76,7 +76,9 @@ class NET_EXPORT CertVerifyProc

FRIEND_TEST_ALL_PREFIXES(CertVerifyProcTest, TestHasTooLongValidity);

// Performs the actual verification using the desired underlying

- // cryptographic library.

+ // cryptographic library. On entry, |verify_result->verified_cert|

+ // is set to |cert|, the unverified chain. If no chain is built, the

+ // value must be left untouched.

virtual int VerifyInternal(X509Certificate* cert,

const std::string& hostname,

int flags,

« no previous file with comments | « no previous file | net/cert/cert_verify_proc_mac.cc » ('j') | net/cert/cert_verify_proc_mac.cc » ('J')