net/cert/x509_certificate_mac.cc - Issue 1094983002: Account for the OS returning an empty certificate chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate_mac.cc

Issue 1094983002: Account for the OS returning an empty certificate chain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: size test cert to a multiple of 8, otherwise key size in bits is weird Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/x509_certificate_mac.cc

diff --git a/net/cert/x509_certificate_mac.cc b/net/cert/x509_certificate_mac.cc

index 10cfb56f4c0279f4041beae594262f03c9ccc64a..c02f33b123d92d31dd3d40ba424cf2b773cab98a 100644

--- a/net/cert/x509_certificate_mac.cc

+++ b/net/cert/x509_certificate_mac.cc

@@ -497,7 +497,9 @@ void X509Certificate::GetPublicKeyInfo(OSCertHandle cert_handle,

SecKeyRef key;

OSStatus status = SecCertificateCopyPublicKey(cert_handle, &key);

if (status) {

- NOTREACHED() << "SecCertificateCopyPublicKey failed: " << status;

+ // SecCertificateCopyPublicKey may fail if the certificate has an invalid

+ // key. See https://crbug.com/472291.

+ LOG(WARNING) << "SecCertificateCopyPublicKey failed: " << status;

return;

}

ScopedCFTypeRef<SecKeyRef> scoped_key(key);

« no previous file with comments | « net/cert/cert_verify_proc_unittest.cc ('k') | net/cert/x509_certificate_unittest.cc » ('j') | no next file with comments »