Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: net/cert/cert_verify_proc.h

Issue 1094983002: Account for the OS returning an empty certificate chain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: size test cert to a multiple of 8, otherwise key size in bits is weird Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/cert/cert_verify_proc_mac.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_CERT_CERT_VERIFY_PROC_H_ 5 #ifndef NET_CERT_CERT_VERIFY_PROC_H_
6 #define NET_CERT_CERT_VERIFY_PROC_H_ 6 #define NET_CERT_CERT_VERIFY_PROC_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 protected: 69 protected:
70 CertVerifyProc(); 70 CertVerifyProc();
71 virtual ~CertVerifyProc(); 71 virtual ~CertVerifyProc();
72 72
73 private: 73 private:
74 friend class base::RefCountedThreadSafe<CertVerifyProc>; 74 friend class base::RefCountedThreadSafe<CertVerifyProc>;
75 FRIEND_TEST_ALL_PREFIXES(CertVerifyProcTest, DigiNotarCerts); 75 FRIEND_TEST_ALL_PREFIXES(CertVerifyProcTest, DigiNotarCerts);
76 FRIEND_TEST_ALL_PREFIXES(CertVerifyProcTest, TestHasTooLongValidity); 76 FRIEND_TEST_ALL_PREFIXES(CertVerifyProcTest, TestHasTooLongValidity);
77 77
78 // Performs the actual verification using the desired underlying 78 // Performs the actual verification using the desired underlying
79 // cryptographic library. 79 // cryptographic library. On entry, |verify_result->verified_cert|
80 // is set to |cert|, the unverified chain. If no chain is built, the
81 // value must be left untouched.
80 virtual int VerifyInternal(X509Certificate* cert, 82 virtual int VerifyInternal(X509Certificate* cert,
81 const std::string& hostname, 83 const std::string& hostname,
82 int flags, 84 int flags,
83 CRLSet* crl_set, 85 CRLSet* crl_set,
84 const CertificateList& additional_trust_anchors, 86 const CertificateList& additional_trust_anchors,
85 CertVerifyResult* verify_result) = 0; 87 CertVerifyResult* verify_result) = 0;
86 88
87 // Returns true if |cert| is explicitly blacklisted. 89 // Returns true if |cert| is explicitly blacklisted.
88 static bool IsBlacklisted(X509Certificate* cert); 90 static bool IsBlacklisted(X509Certificate* cert);
89 91
(...skipping 21 matching lines...) Expand all
111 // requirement they expire within 7 years after the effective date of the BRs 113 // requirement they expire within 7 years after the effective date of the BRs
112 // (i.e. by 1 July 2019). 114 // (i.e. by 1 July 2019).
113 static bool HasTooLongValidity(const X509Certificate& cert); 115 static bool HasTooLongValidity(const X509Certificate& cert);
114 116
115 DISALLOW_COPY_AND_ASSIGN(CertVerifyProc); 117 DISALLOW_COPY_AND_ASSIGN(CertVerifyProc);
116 }; 118 };
117 119
118 } // namespace net 120 } // namespace net
119 121
120 #endif // NET_CERT_CERT_VERIFY_PROC_H_ 122 #endif // NET_CERT_CERT_VERIFY_PROC_H_
OLDNEW
« no previous file with comments | « no previous file | net/cert/cert_verify_proc_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698