Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1094963002: [modules] Parsing: add ModuleRequests where missing (Closed)

Created:
5 years, 8 months ago by adamk
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Parsing: add ModuleRequests where missing Two last forms supported in this patch: - 'import' ModuleSpecifier - 'export' '*' 'from' ModuleSpecifier. BUG=v8:1569 LOG=n Committed: https://crrev.com/4a5c91387bc8c6392ac3186c932d612e929c3faa Cr-Commit-Position: refs/heads/master@{#27927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/parser.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
adamk
another little patch, just filling out stuff around the edges while working on the real ...
5 years, 8 months ago (2015-04-17 21:41:43 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-04-17 22:09:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094963002/1
5 years, 8 months ago (2015-04-17 22:35:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2116)
5 years, 8 months ago (2015-04-17 22:39:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094963002/1
5 years, 8 months ago (2015-04-17 22:43:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-17 22:45:21 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-17 22:45:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a5c91387bc8c6392ac3186c932d612e929c3faa
Cr-Commit-Position: refs/heads/master@{#27927}

Powered by Google App Engine
This is Rietveld 408576698