Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1094903008: Revert of [Android] Add an out-of-app instrumentation driver APK. (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, android-webview-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add an out-of-app instrumentation driver APK. (patchset #15 id:280001 of https://codereview.chromium.org/1034053002/) Reason for revert: Broke the "Android" bot: http://build.chromium.org/p/chromium/builders/Android/builds/38661 Original issue's description: > [Android] Add an out-of-app instrumentation driver APK. > > BUG=444049 > > Committed: https://crrev.com/79d22ed2b74d0ff1082f6febfd3fd93c0574d130 > Cr-Commit-Position: refs/heads/master@{#326900} TBR=tedchoc@chromium.org,klundberg@chromium.org,yfriedman@chromium.org,thestig@chromium.org,cjhopman@chromium.org,torne@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444049 Committed: https://crrev.com/47b4c2f01324a903410ae9530156c2469601e91b Cr-Commit-Position: refs/heads/master@{#326914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -1093 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/javatests/AndroidManifest.xml View 2 chunks +1 line, -3 lines 0 comments Download
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 3 chunks +1 line, -5 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 9 chunks +16 lines, -79 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 chunk +11 lines, -30 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_helper.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_instrumentation_test_run.py View 2 chunks +3 lines, -28 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_test_run.py View 5 chunks +3 lines, -11 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/shell/javatests/AndroidManifest.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -3 lines 0 comments Download
D testing/android/appurify_support.gyp View 1 chunk +0 lines, -22 lines 0 comments Download
D testing/android/appurify_support/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D testing/android/appurify_support/java/src/org/chromium/test/support/ResultsBundleGenerator.java View 1 chunk +0 lines, -30 lines 0 comments Download
D testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java View 1 chunk +0 lines, -56 lines 0 comments Download
D testing/android/broker/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D testing/android/broker/java/src/org/chromium/test/broker/OnDeviceInstrumentationBroker.java View 1 chunk +0 lines, -64 lines 0 comments Download
D testing/android/driver/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D testing/android/driver/java/AndroidManifest.xml View 1 chunk +0 lines, -23 lines 0 comments Download
D testing/android/driver/java/src/org/chromium/test/driver/OnDeviceInstrumentationDriver.java View 1 chunk +0 lines, -271 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/ChromeNativeTestInstrumentationTestRunner.java View 6 chunks +56 lines, -11 lines 0 comments Download
D testing/android/on_device_instrumentation.gyp View 1 chunk +0 lines, -79 lines 0 comments Download
D testing/android/reporter/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusListener.java View 1 chunk +0 lines, -78 lines 0 comments Download
D testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java View 1 chunk +0 lines, -128 lines 0 comments Download
D testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReporter.java View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of [Android] Add an out-of-app instrumentation driver APK.
5 years, 8 months ago (2015-04-24 22:50:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094903008/1
5 years, 8 months ago (2015-04-24 22:52:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 22:53:58 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 22:54:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47b4c2f01324a903410ae9530156c2469601e91b
Cr-Commit-Position: refs/heads/master@{#326914}

Powered by Google App Engine
This is Rietveld 408576698