Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1094903006: Update {virtual,override} to follow C++11 style in base. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in base. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/c0b00106efe0a3737148de518b77ba8273417e69 Cr-Commit-Position: refs/heads/master@{#326392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -38 lines) Patch
M base/files/file_path_watcher_stub.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M base/json/json_value_converter.h View 7 chunks +10 lines, -14 lines 0 comments Download
M base/observer_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_member.h View 2 chunks +4 lines, -4 lines 0 comments Download
M base/test/gtest_xml_util.h View 1 chunk +5 lines, -5 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/threading/thread_perftest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/trace_event/trace_event.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-22 21:05:21 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-22 21:06:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094903006/1
5 years, 8 months ago (2015-04-22 21:16:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 23:17:26 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 23:18:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0b00106efe0a3737148de518b77ba8273417e69
Cr-Commit-Position: refs/heads/master@{#326392}

Powered by Google App Engine
This is Rietveld 408576698