Issue 10949008: Fix up instance registration with the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10949008: Fix up instance registration with the browser. (Closed)

Created:
8 years, 3 months ago by brettw

Modified:
8 years, 2 months ago

Reviewers:
raymes

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix up instance registration with the browser. This code was crashing and was disabled. Previously it would try to send the message through the render view passed to the constructor. But since the dispatcher wrapper outlives any particular RenderView, this crashes. This new code goes through the RendererPpapiHost to get the render view associated with the current instance that's being created or destroyed. BUG=150654 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158889

Patch Set 1 #

Patch Set 2 : fix browser tag test #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -15 lines)			Patch
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View	1	3 chunks	+24 lines, -15 lines	0 comments	Download
M	content/renderer/pepper/renderer_ppapi_host_impl.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/renderer_ppapi_host_impl.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

raymes

8 years, 2 months ago (2012-09-25 15:12:30 UTC) #3

What's the status of this? I think this is needed before I commit the printing
stuff.

Expand Messages | Collapse Messages