Extensions: Switch to new permission message system, part V

extensions/common/PRESUBMIT.py

Index: extensions/common/PRESUBMIT.py
diff --git a/extensions/browser/PRESUBMIT.py b/extensions/common/PRESUBMIT.py
similarity index 64%
copy from extensions/browser/PRESUBMIT.py
copy to extensions/common/PRESUBMIT.py
index 4e7acef51d28781f48cb2426bc7003346b1df964..cbfb2b6368cde85727333a957fe1bc9536e27a4d 100644
--- a/extensions/browser/PRESUBMIT.py
+++ b/extensions/common/PRESUBMIT.py
@@ -1,8 +1,8 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-"""Chromium presubmit script for src/extensions/browser.
+"""Chromium presubmit script for src/extensions/common.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details on the presubmit API built into depot_tools.
@@ -10,7 +10,7 @@ for more details on the presubmit API built into depot_tools.
 
 import sys
 
-def _CreateHistogramValueChecker(input_api, output_api):
+def _CreateAPIPermissionIDChecker(input_api, output_api):
   original_sys_path = sys.path
 
   try:
@@ -22,14 +22,14 @@ def _CreateHistogramValueChecker(input_api, output_api):
     sys.path = original_sys_path
 
   return StrictEnumValueChecker(input_api, output_api,
-      start_marker='enum HistogramValue {', end_marker='  // Last entry:',
-      path='extensions/browser/extension_function_histogram_value.h')
+      start_marker='  enum ID {', end_marker='    // Last entry:',
+      path='extensions/common/api_permission.h')
 
 def CheckChangeOnUpload(input_api, output_api):
   results = []
-  results += _CreateHistogramValueChecker(input_api, output_api).Run()
+  results += _CreateAPIPermissionIDChecker(input_api, output_api).Run()
   results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)

[Marc Treib, 2015/04/29 11:24:02]

extensions/browser has this format check, I think it makes sense to have it for
extensions/common as well. WDYT?

[Devlin, 2015/04/29 15:42:24]

Eh, probably, as long as it's not a commit blocker (which it isn't here).

   return results
 
 def CheckChangeOnCommit(input_api, output_api):
-  return _CreateHistogramValueChecker(input_api, output_api).Run()
+  return _CreateAPIPermissionIDChecker(input_api, output_api).Run()