Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/metrics/histograms/update_histogram_enum.py

Issue 1094873002: Extensions: Switch to new permission message system, part V (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/histograms/update_histogram_enum.py
diff --git a/tools/metrics/histograms/update_histogram_enum.py b/tools/metrics/histograms/update_histogram_enum.py
index 98d70acde103caa884d8de5c8a5cc6de904058a6..fc2c1b84d90b572a393d7b5b77c2ec5975aa8354 100644
--- a/tools/metrics/histograms/update_histogram_enum.py
+++ b/tools/metrics/histograms/update_histogram_enum.py
@@ -89,12 +89,12 @@ def UpdateHistogramDefinitions(histogram_enum_name, source_enum_values,
doesn't contain any corresponding data will be preserved. |source_enum_path|
will be used to insert a comment.
"""
- # Get a dom of <enum name=|name| ...> node in |document|.
+ # Get a dom of <enum name=|histogram_enum_name| ...> node in |document|.
for enum_node in document.getElementsByTagName('enum'):
if enum_node.attributes['name'].value == histogram_enum_name:
break
else:
- raise UserError('No {0} enum node found'.format(name))
+ raise UserError('No {0} enum node found'.format(histogram_enum_name))
new_item_nodes = {}
new_comments = []

Powered by Google App Engine
This is Rietveld 408576698