Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: extensions/common/PRESUBMIT.py

Issue 1094873002: Extensions: Switch to new permission message system, part V (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/PRESUBMIT.py
diff --git a/extensions/browser/PRESUBMIT.py b/extensions/common/PRESUBMIT.py
similarity index 64%
copy from extensions/browser/PRESUBMIT.py
copy to extensions/common/PRESUBMIT.py
index 4e7acef51d28781f48cb2426bc7003346b1df964..cbfb2b6368cde85727333a957fe1bc9536e27a4d 100644
--- a/extensions/browser/PRESUBMIT.py
+++ b/extensions/common/PRESUBMIT.py
@@ -1,8 +1,8 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
+# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Chromium presubmit script for src/extensions/browser.
+"""Chromium presubmit script for src/extensions/common.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details on the presubmit API built into depot_tools.
@@ -10,7 +10,7 @@ for more details on the presubmit API built into depot_tools.
import sys
-def _CreateHistogramValueChecker(input_api, output_api):
+def _CreateAPIPermissionIDChecker(input_api, output_api):
original_sys_path = sys.path
try:
@@ -22,14 +22,14 @@ def _CreateHistogramValueChecker(input_api, output_api):
sys.path = original_sys_path
return StrictEnumValueChecker(input_api, output_api,
- start_marker='enum HistogramValue {', end_marker=' // Last entry:',
- path='extensions/browser/extension_function_histogram_value.h')
+ start_marker=' enum ID {', end_marker=' // Last entry:',
+ path='extensions/common/api_permission.h')
def CheckChangeOnUpload(input_api, output_api):
results = []
- results += _CreateHistogramValueChecker(input_api, output_api).Run()
+ results += _CreateAPIPermissionIDChecker(input_api, output_api).Run()
results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
return results
def CheckChangeOnCommit(input_api, output_api):
- return _CreateHistogramValueChecker(input_api, output_api).Run()
+ return _CreateAPIPermissionIDChecker(input_api, output_api).Run()

Powered by Google App Engine
This is Rietveld 408576698