chrome/browser/extensions/navigation_observer.cc - Issue 1094873002: Extensions: Switch to new permission message system, part V

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/navigation_observer.cc

Issue 1094873002: Extensions: Switch to new permission message system, part V (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/installed_loader.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/navigation_observer.cc

diff --git a/chrome/browser/extensions/navigation_observer.cc b/chrome/browser/extensions/navigation_observer.cc

index 7544f701d46da49cf91aa7571ce2f9f8a3c6884e..289a8b84377acb7acfb87ffeee1185310a4baef7 100644

--- a/chrome/browser/extensions/navigation_observer.cc

+++ b/chrome/browser/extensions/navigation_observer.cc

@@ -111,9 +111,8 @@ void NavigationObserver::InstallUIAbort(bool user_initiated) {

in_progress_prompt_navigation_controller_ = NULL;

extension_install_prompt_.reset();

- std::string histogram_name = user_initiated

- ? "Extensions.Permissions_ReEnableCancel2"

- : "Extensions.Permissions_ReEnableAbort2";

+ std::string histogram_name = user_initiated ? "ReEnableCancel"

+ : "ReEnableAbort";

ExtensionService::RecordPermissionMessagesHistogram(

extension, histogram_name.c_str());

}