Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 1094873002: Extensions: Switch to new permission message system, part V (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
index c4406ee37808af38bb6b79d54f4afe8a0ef820ee..d03bf541ec0c400a0f562667bebb684ec66fd85b 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -427,7 +427,7 @@ void WebstorePrivateBeginInstallWithManifest3Function::InstallUIProceedHook() {
// for all extension installs, so we only need to record the web store
// specific histogram here.
ExtensionService::RecordPermissionMessagesHistogram(
- dummy_extension().get(), "Extensions.Permissions_WebStoreInstall2");
+ dummy_extension().get(), "WebStoreInstall");
}
void WebstorePrivateBeginInstallWithManifest3Function::InstallUIAbortHook(
@@ -435,14 +435,12 @@ void WebstorePrivateBeginInstallWithManifest3Function::InstallUIAbortHook(
// The web store install histograms are a subset of the install histograms.
// We need to record both histograms here since CrxInstaller::InstallUIAbort
// is never called for web store install cancellations.
- std::string histogram_name =
- user_initiated ? "Extensions.Permissions_WebStoreInstallCancel2"
- : "Extensions.Permissions_WebStoreInstallAbort2";
+ std::string histogram_name = user_initiated ? "WebStoreInstallCancel"
+ : "WebStoreInstallAbort";
ExtensionService::RecordPermissionMessagesHistogram(dummy_extension().get(),
histogram_name.c_str());
- histogram_name = user_initiated ? "Extensions.Permissions_InstallCancel2"
- : "Extensions.Permissions_InstallAbort2";
+ histogram_name = user_initiated ? "InstallCancel" : "InstallAbort";
ExtensionService::RecordPermissionMessagesHistogram(dummy_extension().get(),
histogram_name.c_str());
}
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698