Extensions: Switch to new permission message system, part V

extensions/common/permissions/api_permission.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_PERMISSIONS_API_PERMISSION_H_
 #define EXTENSIONS_COMMON_PERMISSIONS_API_PERMISSION_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 16 matching lines @@
 class ChromeAPIPermissions;
 
 // APIPermission is for handling some complex permissions. Please refer to
 // extensions::SocketPermission as an example.
 // There is one instance per permission per loaded extension.
 class APIPermission {
  public:
   // The IDs of all permissions available to apps. Add as many permissions here
   // as needed to generate meaningful permission messages. Add the rules for the
   // messages to ChromePermissionMessageProvider.
-  // Remove permissions from this list if they have no longer have a
-  // corresponding API permission and no permission message.
+  // Do not reorder this enumeration or remove any entries. If you need to add a
+  // new entry, add it just prior to kEnumBoundary, and ensure to update the
+  // "ExtensionPermission3" enum in tools/metrics/histograms/histograms.xml
+  // (by running update_extension_permission.py).
   // TODO(sashab): Move this to a more central location, and rename it to
   // PermissionID.
   enum ID {
     // Error codes.
-    kInvalid = -2,
-    kUnknown = -1,
+    kInvalid,
+    kUnknown,
 
-    // Real permissions.
+    // Actual permission IDs. Not all of these are valid permissions on their
+    // own; some are just needed by various manifest permissions to represent
+    // their permission message rule combinations.
     kAccessibilityFeaturesModify,
     kAccessibilityFeaturesRead,
     kAccessibilityPrivate,
     kActiveTab,
     kActivityLogPrivate,
     kAlarms,
     kAlphaEnabled,
     kAlwaysOnTopWindows,
     kAppView,
     kAudio,
@@ skipping 149 matching lines @@
     kWebrtcLoggingPrivate,
     kWebstorePrivate,
     kWebView,
     kWindowShape,
     kScreenlockPrivate,
     kSystemCpu,
     kSystemMemory,
     kSystemNetwork,
     kSystemInfoCpu,
     kSystemInfoMemory,
-
-    // Permission message IDs that are not currently valid permissions on their
-    // own, but are needed by various manifest permissions to represent their
-    // permission message rule combinations.
-    // TODO(sashab): Move these in-line with the other permission IDs.
     kBluetooth,
     kBluetoothDevices,
     kFavicon,
     kFullAccess,
     kHostReadOnly,
     kHostReadWrite,
     kHostsAll,
     kHostsAllReadOnly,
     kMediaGalleriesAllGalleriesCopyTo,
     kMediaGalleriesAllGalleriesDelete,
     kMediaGalleriesAllGalleriesRead,
     kNetworkState,
     kOverrideBookmarksUI,
     kShouldWarnAllHosts,
     kSocketAnyHost,
     kSocketDomainHosts,
     kSocketSpecificHosts,
     kUsbDeviceList,
     kUsbDeviceUnknownProduct,
     kUsbDeviceUnknownVendor,
-
+    // Last entry: Add new entries above and ensure to update the
+    // "ExtensionPermission3" enum in tools/metrics/histograms/histograms.xml
+    // (by running update_extension_permission.py).
     kEnumBoundary
   };
 
   struct CheckParam {
   };
 
   explicit APIPermission(const APIPermissionInfo* info);
 
   virtual ~APIPermission();
 
@@ skipping 196 matching lines @@
   const char* const name_;
   const int flags_;
   const int l10n_message_id_;
   const PermissionMessage::ID message_id_;
   const APIPermissionConstructor api_permission_constructor_;
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_PERMISSIONS_API_PERMISSION_H_