Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 1094863006: Put display messages as 'additional' message. (Closed)

Created:
5 years, 8 months ago by Jun Mukai
Modified:
5 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put display messages as 'additional' message. Notification title has 2-line limit, therefore sometimes long messages are cut off. The 'body' field has much more space for longer text. BUG=454827 R=oshima@chromium.org TEST=manually Committed: https://crrev.com/bf215fe52623ad5ab594153ca1182ffe4a4537d3 Cr-Commit-Position: refs/heads/master@{#326692}

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -54 lines) Patch
M ash/system/chromeos/tray_display.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M ash/system/chromeos/tray_display_unittest.cc View 1 3 chunks +38 lines, -47 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jun Mukai
5 years, 8 months ago (2015-04-17 21:56:23 UTC) #1
oshima
lgtm
5 years, 8 months ago (2015-04-17 22:58:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094863006/1
5 years, 8 months ago (2015-04-17 23:06:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/8816)
5 years, 8 months ago (2015-04-18 01:10:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1094863006/20001
5 years, 8 months ago (2015-04-23 23:01:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 23:40:03 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 23:40:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf215fe52623ad5ab594153ca1182ffe4a4537d3
Cr-Commit-Position: refs/heads/master@{#326692}

Powered by Google App Engine
This is Rietveld 408576698